Adding Change Department to updateTicketProperties()

Looks like its working. Here is the code. I have not added any validation as that is not part of my project guidelines. Please let me know if there are any bugs or if you elaborate on the code adding validation etc so I can update mine as well. I have to move on to the next piece of this API development. Hope you find this useful!

api.class.php

CODE

    public static function updateTicketProperties($user, $password, $email, $ticketId, $newStatus=0, $newPriority=0, $newDepartment=0) {
        global $_SWIFT, $dbCore, $CONF;

        require_once 'modules/tickets/functions_ticketmain.php';
        require_once 'modules/tickets/functions_ticketcore.php';

        //First we check the fields
        if (!self::isApiUserValid($user, $password))
            return self::ERR_INCORRECT_API_USER_CREDENTIALS;

        if (!isValidEmail($email))
            return self::ERR_INVALID_EMAIL;

        $ticketId = (int) $ticketId;

        if (($userId = getUserEmail($email)) === false)
            return self::ERR_NON_EXISTENT_USER;

        if ($newPriority == 0 && $newStatus == 0 && $newDepartment == 0)
            return self::ERR_STATUS_AND_PRIORITY_BOTH_EMPTY;

        $ticketObj = new TicketMain($ticketId, false);

        if (empty($ticketObj->ticket['ticketid']))
            return self::ERR_NON_EXISTENT_TICKET;

        $ticket = $ticketObj->ticket;

        $userArr = fetchUser($ticket['userid']);

        if ($userArr['userid'] != $userId)
            return self::ERR_TICKET_REQUESTED_FOR_INCORRECT_USER;

        if ($newPriority != 0) {
            $prioritylist = self::getPriorityList($user, $password);

            $ispresent = false;
            foreach ($prioritylist as $priority) {
                if ($newPriority == $priority['id']) {
                    $ispresent = true;
                    break;
                }
            }

            if (!$ispresent)
                return self::ERR_NON_EXISTENT_PRIORITY;
        }

        if ($newStatus != 0) {
            $statuslist = self::getStatusList($user, $password);

            $ispresent = false;
            foreach ($statuslist as $status) {
                if ($newStatus == $status['id']) {
                    $ispresent = true;
                    break;
                }
            }

            if (!$ispresent)
                return self::ERR_NON_EXISTENT_STATUS;
        }

        if ($newPriority) $ticketObj->changePriority($newPriority);
        if ($newStatus) $ticketObj->changeStatus($newStatus);
        if ($newDepartment != 0) $ticketObj->moveTicket($newDepartment);

        //Refresh the department count
        $myDepartmentList = self::getDepartmentList($user, $password);
        foreach ($myDepartmentList as $department){
            $departmentList[] = $department['id'];
        }
        $_SWIFT["recountdep"] = $departmentList;
        recountTicketDepartments();

        return true;
    }

wsdl.php

CODE

$soapMethods['updateTicketProperties'] = array(
        'input' => array(    'email' => 'xsd:string',
                            'ticketId' => 'xsd:int',
                            'newStatus' => 'xsd:int',
                            'newPriority'=>'xsd:int',
                            'newDepartment'=>'xsd:int'
                        ),
        'output' => array(    'successful' => 'xsd:boolean' ),
        'desc' => 'Updates the status and/or priority of the specified ticket, returning true if successful'
    );
function updateTicketProperties($user, $password, $email, $ticketId, $newStatus, $newPriority, $newDepartment) {
    return processSoapResult(CBS_KayakoAPI::updateTicketProperties($user, $password, $email, $ticketId, $newStatus, $newPriority, $newDepartment));
}

Craig Brass Systems Forum: Adding Change Department to updateTicketProperties() - Craig Brass Systems Forum